Repository navigation
Conversation
7a22815 to
5cb1d22
Compare
|
Self-review passed. I reviewed the complete diff and relevant surrounding code. No actionable issues were found, so no fixes were needed. Verification:
|
…ed-pipe-consensus-subscription # Conflicts: # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/load/LoadTsFileAnalyzer.java
|
CI follow-up for ada233a. The failed run reported five test errors from the renamed dataTablePattern field and four stale LOAD model-cache field references. Updated historical-source tests to use dataTablePattern, LOAD diagnostics tests to seed LoadTsFileModelCache, and projector coverage to assert the TabletBatch API. Resolved the SubscriptionPipeTabletEventBatch conflict by retaining the batch-scoped projector provider and master tablet-size recalculation after filtering. Verification: Spotless apply passed; focused datanode reactor run passed 54 tests with 0 failures and 0 errors; git diff --check passed. The fixes are in reviewed commit ada233a, matching both local and remote PR heads. PR remains Draft pending a fresh independent review of the final diff. |
Description
Refactors shared Pipe, IoTConsensus, and subscription code into focused helpers while retaining existing behavior. Adds an indexed model cache for TSFile LOAD analysis so mini-file conversion and tablet fallback dispatch by each file's actual model.
For input
[tree-a.tsfile, table-a.tsfile, tree-b.tsfile], the cache retains model flags[false, true, false], and tablet fallback dispatches tree/table/tree converters. The reliable index advances only after each file's model metadata is read and classified.PipeBatchMetricsSettableand extract batch detachment while preserving synchronization and atomic ownership handoff.TableViewTabletProjectorProvider; keep projector lifetime scoped to each batch and preserve topic configuration snapshots, TAG filtering, column pruning, and WAL replay.Validation
git diff --checkpasses.LoadTsFileModelCacheTestandtest-compileremain unverified because the external test volume was unavailable; no test data or temporary files were redirected to the system drive.